Make nvme_metrics.py work with missing paths#245
Closed
deajan wants to merge 1 commit intoprometheus-community:masterfrom
Closed
Make nvme_metrics.py work with missing paths#245deajan wants to merge 1 commit intoprometheus-community:masterfrom
deajan wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
Signed-off-by: Orsiris de Jong <ozy@netpower.fr>
Member
|
Coding (even multiple) paths into scripts is not a portable approach. It is not the script's responsibility to find the binary. Such functionality should be handled by the PATH environment, which should be suitably configured prior to launching the script (e.g. in the crontab). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On RHEL9, running via cron without PATH variable fails.
This checks for proper path for nvme binary.